You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This enhancement is completely forwards/backwards compatible
Mentions in the documentation are included in the PR corresponding to this issue
Pitch
Googling ForkingUnixStreamServer shows a few people / codebases which define such a class in the same manner as above. I myself have done so in a project.
These classes seem to have been overlooked because they require two if checks for hasattr(socket, "AF_UNIX") and hasattr(os, "fork").
It seems clear to me therefore that these two classes should be added to the socketserver standard library module
…mServer socketservers (#103674)
sockserver gains ForkingUnixStreamServer and ForkingUnixDatagramServer classes for consistency with all of the others. Ironically these existed but were buried in our test suite.
Addresses #103673
<!-- gh-issue-number: gh-103673 -->
* Issue: gh-103673
<!-- /gh-issue-number -->
---------
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Enhancement
This issue / PR addresses two missing servers from the
socketserver
moduleCurrent behaviour
socketserver has the following
Observe the two gaps marked by "???"
Proposal
In the case
hasattr(socket, "AF_UNIX") and hasattr(os, "fork")
we enable the two missing servers asThese follow the established naming convention
This enhancement is completely forwards/backwards compatible
Mentions in the documentation are included in the PR corresponding to this issue
Pitch
Googling
ForkingUnixStreamServer
shows a few people / codebases which define such a class in the same manner as above. I myself have done so in a project.These classes seem to have been overlooked because they require two
if
checks forhasattr(socket, "AF_UNIX")
andhasattr(os, "fork")
.It seems clear to me therefore that these two classes should be added to the
socketserver
standard library moduleSome people prefer forks to threads
Linked PRs
The text was updated successfully, but these errors were encountered: