Skip to content

The sqlite3 module should not be built as a core module #106104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erlend-aasland opened this issue Jun 26, 2023 · 1 comment
Closed

The sqlite3 module should not be built as a core module #106104

erlend-aasland opened this issue Jun 26, 2023 · 1 comment
Assignees
@erlend-aasland
Labels
extension-modules C modules in the Modules dir topic-sqlite3 type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 26, 2023 •
edited by bedevere-bot
Loading

The sqlite3 extension module accidentally got upped as a core module (Py_BUILD_CORE_MODULE) in gh-105927. We'd like to keep most extension modules away from the internal API, so I'm reverting this specific change.

cc. @vstinner

Linked PRs
@erlend-aasland erlend-aasland added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir topic-sqlite3 labels Jun 26, 2023
@erlend-aasland erlend-aasland self-assigned this Jun 26, 2023
@bedevere-bot bedevere-bot mentioned this issue Jun 26, 2023
Closed
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 26, 2023
@erlend-aasland
pythongh-106104: Use public weakref APIs in sqlite3
43cbf83 
The sqlite3 extension module should be built using the public API, so
we're removing the Py_BUILD_CORE_MODULE define that was introduced as
part of the pythongh-105927 changes.
@erlend-aasland erlend-aasland linked a pull request Jun 26, 2023 that will close this issue
gh-106104: Use public weakref APIs in sqlite3 #106105
Closed
@erlend-aasland erlend-aasland moved this to In Progress in sqlite3 issues Jun 26, 2023
@erlend-aasland
Copy link
Contributor Author

As noted on the issue, I don't plan to follow this up. See #106105 (comment). If we decide to convert the _sqlite3 extension module to use the Limited API in the future, we can revisit this.

@erlend-aasland erlend-aasland closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in sqlite3 issues Oct 22, 2023
@erlend-aasland erlend-aasland moved this from Done to Discarded in sqlite3 issues Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
extension-modules C modules in the Modules dir topic-sqlite3 type-bug An unexpected behavior, bug, or error
Projects
sqlite3 issues
Status: Discarded
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-106104: Use public weakref APIs in sqlite3 erlend-aasland/cpython
1 participant
@erlend-aasland