Skip to content

Add more tests for formatting floats and fractions #109546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Sep 18, 2023 · 2 comments
Closed

Add more tests for formatting floats and fractions #109546

serhiy-storchaka opened this issue Sep 18, 2023 · 2 comments
Labels
3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 18, 2023 •
edited by bedevere-app bot
Loading

File "formatfloat_testcases.txt" contains test cases for testing printf-like formatting of floats. The same data can be used for testing new-style formatting of floats (they give the same result) and float-style formatting of Fraction (added in 3.12).

cc @mdickinson

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.12 only security fixes 3.13 bugs and security fixes labels Sep 18, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Sep 18, 2023
@serhiy-storchaka
pythongh-109546: Add more tests for formatting floats and fractions
948747a
@bedevere-app bedevere-app bot mentioned this issue Sep 18, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Sep 19, 2023
@serhiy-storchaka
gh-109546: Add more tests for formatting floats and fractions (GH-109548
beb5ec5 
)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 19, 2023
@serhiy-storchaka @miss-islington
pythongh-109546: Add more tests for formatting floats and fractions (p…
379f0a2 
…ythonGH-109548)

(cherry picked from commit beb5ec5)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Sep 19, 2023
Merged
@serhiy-storchaka
Copy link
Member Author

I tried also to use this file in test_decimal, but decimals produce very different output.

I am not sure about test_complex. On one hand, complex formatting uses the same PyOS_double_to_string() as float formatting. On other hand, there is a code between __format__() and PyOS_double_to_string() which can affect interpretation of the format string.

@vstinner
Copy link
Member

It's already great to use it in test_fractions! And that you added more tests in test_float.

vstinner pushed a commit to vstinner/cpython that referenced this issue Sep 21, 2023
@serhiy-storchaka @vstinner
pythongh-109546: Add more tests for formatting floats (pythonGH-109548)
6f0c599 
(cherry picked from commit beb5ec5)
@bedevere-app bedevere-app bot mentioned this issue Sep 21, 2023
Merged
vstinner added a commit that referenced this issue Sep 21, 2023
@vstinner @serhiy-storchaka
[3.11] gh-109546: Add more tests for formatting floats (GH-109548) (#…
84d8fdb 
…109685)

gh-109546: Add more tests for formatting floats (GH-109548)

(cherry picked from commit beb5ec5)

Co-authored-by: Serhiy Storchaka <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 28, 2023
@serhiy-storchaka @csm10495
pythongh-109546: Add more tests for formatting floats and fractions (p…
be83a3a 
…ythonGH-109548)
Yhg1s pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-109546: Add more tests for formatting floats and fractions (G…
acb6753 
…H-109548) (#109557)

gh-109546: Add more tests for formatting floats and fractions (GH-109548)
(cherry picked from commit beb5ec5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @serhiy-storchaka