Skip to content

Missing error check in _testinternalcapi #110241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Oct 2, 2023 · 0 comments
Closed

Missing error check in _testinternalcapi #110241

sobolevn opened this issue Oct 2, 2023 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 2, 2023 •
edited by bedevere-app bot
Loading

Bug report

While looking at #110238 I've noticed that

cpython/Modules/_testinternalcapi.c

Line 678 in 014aacd

PyList_Append(state->record_list, ((PyFunctionObject *)f->f_funcobj)->func_name);
does not handle errors properly.

I have a PR ready :)

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Oct 2, 2023
@sobolevn sobolevn self-assigned this Oct 2, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 2, 2023
@sobolevn
pythongh-110241: Add missing error check to record_eval in `_testin…
4b0b2db 
…ternalcapi`
@bedevere-app bedevere-app bot mentioned this issue Oct 2, 2023
Merged
JelleZijlstra pushed a commit that referenced this issue Oct 2, 2023
@sobolevn
gh-110241: Add missing error check to record_eval in `_testinternal…
4596c76 
…capi` (#110242)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 2, 2023
@sobolevn @miss-islington
pythongh-110241: Add missing error check to record_eval in `_testin…
4431a58 
…ternalcapi` (pythonGH-110242)

(cherry picked from commit 4596c76)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 2, 2023
Merged
JelleZijlstra pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @sobolevn
[3.12] gh-110241: Add missing error check to record_eval in `_testi…
892b194 
…nternalcapi` (GH-110242) (#110244)

gh-110241: Add missing error check to `record_eval` in `_testinternalcapi` (GH-110242)
(cherry picked from commit 4596c76)

Co-authored-by: Nikita Sobolev <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@sobolevn @Glyphack
pythongh-110241: Add missing error check to record_eval in `_testin…
f92985b 
…ternalcapi` (python#110242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serhiy-storchaka @sobolevn