-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
socket.htons uses unnecessary METH_VARARGS #111662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is a larger patch in #64373 that converts the socket module to Argument Clinic. It would automatically apply such optimization for these functions and for many other. |
The main idea of this issue is replacing calling convention to METH_O when needed. I think the clinic argument is optional here |
@serhiy-storchaka moreover, I don't think this patch is actual since there are now |
#111661 updated several methods to use AC tool instead of manual parsing. |
Feature or enhancement
Proposal:
By replacing calling convention to
METH_O
it will run fasterHas this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
The text was updated successfully, but these errors were encountered: