Skip to content

os_support.can_chmod() is broken #113090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Dec 14, 2023 · 0 comments
Closed

os_support.can_chmod() is broken #113090

serhiy-storchaka opened this issue Dec 14, 2023 · 0 comments
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 14, 2023 •
edited by bedevere-app bot
Loading

test.support.os_support.can_chmod() tests for hasattr(os, "chown") instead of hasattr(os, "chmod"). This, and also the fact that it tests bits not supported on Windows, makes it always returning False on Windows. It may make some meaningful tests skipped on Windows and prevents of using it in new tests for os.chmod().

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Dec 14, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows
2517a31
@bedevere-app bedevere-app bot mentioned this issue Dec 14, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@serhiy-storchaka
gh-113090: Fix test.support.os_support.can_chmod() on Windows (GH-113091
c6e953b 
)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka @miss-islington
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows (p…
23fdd0a 
…ythonGH-113091)

(cherry picked from commit c6e953b)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka @miss-islington
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows (p…
388d92a 
…ythonGH-113091)

(cherry picked from commit c6e953b)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Dec 14, 2023
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-113090: Fix test.support.os_support.can_chmod() on Windows (G…
913051d 
…H-113091) (GH-113099)

(cherry picked from commit c6e953b)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-113090: Fix test.support.os_support.can_chmod() on Windows (G…
08ff6fa 
…H-113091) (GH-113100)

(cherry picked from commit c6e953b)

Co-authored-by: Serhiy Storchaka <[email protected]>
corona10 pushed a commit to corona10/cpython that referenced this issue Dec 15, 2023
@serhiy-storchaka @corona10
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows (p…
6d16217 
…ythonGH-113091)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows (p…
e7cb7f7 
…ythonGH-113091)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-113090: Fix test.support.os_support.can_chmod() on Windows (p…
c685659 
…ythonGH-113091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka