Skip to content

Makefile does not capture mimalloc header dependencies #113330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Dec 20, 2023 · 0 comments
Closed

Makefile does not capture mimalloc header dependencies #113330

colesbury opened this issue Dec 20, 2023 · 0 comments
Labels
3.13 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Dec 20, 2023 •
edited by bedevere-app bot
Loading

Bug report

Modifying pycore_mimalloc.h or any of the mimalloc/*.h files does not trigger recompilation of C files as one would expect. The problem is that we should use $(MIMALLOC_HEADERS) instead of @MIMALLOC_HEADERS@ in Makefile.pre.in.

cpython/Makefile.pre.in

Lines 1798 to 1802 in 713e428

$(srcdir)/Include/cpython/weakrefobject.h \
\
@MIMALLOC_HEADERS@ \
\
$(srcdir)/Include/internal/pycore_abstract.h \

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error build The build process and cross-build 3.13 bugs and security fixes labels Dec 20, 2023
colesbury added a commit to colesbury/cpython that referenced this issue Dec 20, 2023
@colesbury
pythongh-113330: Fix mimalloc headers reference
f0ba61e 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
@bedevere-app bedevere-app bot mentioned this issue Dec 20, 2023
Merged
erlend-aasland pushed a commit that referenced this issue Dec 20, 2023
@colesbury
gh-113330: Fix mimalloc headers reference (#113331)
a3e8afe 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
ryan-duve pushed a commit to ryan-duve/cpython that referenced this issue Dec 26, 2023
@colesbury @ryan-duve
pythongh-113330: Fix mimalloc headers reference (python#113331)
efdd4e1 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
kulikjak pushed a commit to kulikjak/cpython that referenced this issue Jan 22, 2024
@colesbury @kulikjak
pythongh-113330: Fix mimalloc headers reference (python#113331)
aac6a22 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@colesbury @aisk
pythongh-113330: Fix mimalloc headers reference (python#113331)
bc0f648 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@colesbury @Glyphack
pythongh-113330: Fix mimalloc headers reference (python#113331)
738862b 
The `MIMALLOC_HEADERS` variable is defined in the Makefile.pre.in, not
the configure script, so we should use the `$(MIMALLOC_HEADERS)` syntax
instead of the `@MIMALLOC_HEADERS@` syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @erlend-aasland