Closed
Description
Feature or enhancement
Proposal:
DictConfigurator.configure_formatter()
and configure_handler()
contain workarounds for old configurations
Lines 670 to 676 in bcccf1f
Lines 844 to 851 in bcccf1f
Django doesn't use fmt
and strm
for many years. I think both can be deprecated and removed.
I'd like to prepare a patch, if accepted.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
Metadata
Metadata
Assignees
Projects
Status
Done
Milestone
Relationships
Development
No branches or pull requests
Activity
sobolevn commentedon Feb 7, 2024
cc @vsajip
vsajip commentedon Feb 7, 2024
I realise Django doesn't use them any more, but what about other code / users? I wouldn't strongly object to removing them, but there's a chance that any such change might need to be reverted if there are complaints that it breaks existing code somewhere. And, of course, no backporting of any such change. Perhaps deprecate, but not remove immediately - rather, in line with the usual deprecation cycle. It's just a little wart in the current code, after all.
felixxm commentedon Feb 7, 2024
Yes that's what I was trying to propose. We have an existing and straightforward upgrade path i.e. use
format
instead offmt
and usestream
instead ofstrm
, so it seems fine to deprecate the current workarounds and remove them in 3.15 (I guess 🤔).True, but they become an issue when there are dozens of such workarounds ("death by a thousand cuts").
vsajip commentedon Feb 7, 2024
Well, it's not that bad IMO, but I'll look at a PR that does deprecation.
felixxm commentedon Feb 11, 2024
While preparing a patch, I noticed that we can deprecate
strm
, however,fmt
is still needed becauseconfig
is passed directly to the custom formatters andFormatter
exceptfmt
instead offormat
.pythongh-115032: Update DictConfigurator.configure_formatter() commen…
fmt
retry. #115303pythongh-115032: Deprecate support for custom logging handlers with '…
pythongh-115032: Deprecate support for custom logging handlers with '…
gh-115032: Update DictConfigurator.configure_formatter() comment abou…
pythongh-115032: Update DictConfigurator.configure_formatter() commen…
pythongh-115032: Deprecate support for custom logging handlers with '…
gh-115032: Deprecate support for custom logging handlers with 'strm' …