Skip to content

pystats: Uop "miss" counts are incorrect #117457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Apr 2, 2024 · 0 comments
Closed

pystats: Uop "miss" counts are incorrect #117457

mdboom opened this issue Apr 2, 2024 · 0 comments
Assignees
@mdboom
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Apr 2, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

After the trace stitching, all uop miss counts are attributed to either _DEOPT or _SIDE_EXIT. These should instead by counted for the uop immediately prior.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Apr 2, 2024
@mdboom mdboom self-assigned this Apr 2, 2024
mdboom added a commit to mdboom/cpython that referenced this issue Apr 2, 2024
@mdboom
pythongh-117457: Correct pystats uop "miss" counts
eab6750
mdboom added a commit to mdboom/cpython that referenced this issue Apr 2, 2024
@mdboom
pythongh-117457: Correct pystats uop "miss" counts
ee60448
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Merged
brandtbucher pushed a commit that referenced this issue Apr 4, 2024
@mdboom
GH-117457: Correct pystats uop "miss" counts (GH-117477)
0edde64
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 5, 2024
@erlend-aasland
pythongh-117457: Regen executor cases post PR python#117477
a808494
@bedevere-app bedevere-app bot mentioned this issue Apr 5, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 5, 2024
@erlend-aasland
gh-117457: Regen executor cases post PR #117477 (#117559)
757b624
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@mdboom @diegorusso
pythonGH-117457: Correct pystats uop "miss" counts (pythonGH-117477)
d492819
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117457: Regen executor cases post PR python#117477 (python#1…
9e454d1 
…17559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @erlend-aasland