Skip to content

Several unused functions in posixmodule.c under WASI build #120586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Jun 16, 2024 · 1 comment
Closed

Several unused functions in posixmodule.c under WASI build #120586

sobolevn opened this issue Jun 16, 2024 · 1 comment
Assignees
@sobolevn
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 16, 2024 •
edited by bedevere-app bot
Loading

Bug report

../../Modules/posixmodule.c:7883:1: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function]
../../Modules/posixmodule.c:12545:1: warning: unused function 'major_minor_conv' [-Wunused-function]
../../Modules/posixmodule.c:12556:1: warning: unused function 'major_minor_check' [-Wunused-function]

Link: https://buildbot.python.org/all/#/builders/1046/builds/5439

The problem is that these helpers are defined without a #ifdef guard, while functions that use them have a conditional definition.

I propose to add the same conditions to these functions as well.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir labels Jun 16, 2024
@sobolevn sobolevn self-assigned this Jun 16, 2024
@sobolevn
Copy link
Member Author

sobolevn commented Jun 16, 2024 •
edited
Loading

Refs 7111d96 and e72830353216

sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 16, 2024
@sobolevn
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
b9e53f7 
…le.c`
@bedevere-app bedevere-app bot mentioned this issue Jun 16, 2024
Merged
sobolevn added a commit that referenced this issue Jun 17, 2024
@sobolevn
gh-120586: Fix several "unused function" warnings in posixmodule.c (#…
3df2022 
…120588)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 17, 2024
@sobolevn @miss-islington
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
7f4e882 
…le.c` (pythonGH-120588)

(cherry picked from commit 3df2022)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 17, 2024
@sobolevn @miss-islington
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
9a55833 
…le.c` (pythonGH-120588)

(cherry picked from commit 3df2022)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Merged
sobolevn added a commit that referenced this issue Jun 17, 2024
@miss-islington @sobolevn
[3.12] gh-120586: Fix several "unused function" warnings in `posixmod…
e004914 
…ule.c` (GH-120588) (#120617)

gh-120586: Fix several "unused function" warnings in `posixmodule.c` (GH-120588)
(cherry picked from commit 3df2022)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this issue Jun 17, 2024
@miss-islington @sobolevn
[3.13] gh-120586: Fix several "unused function" warnings in `posixmod…
03b89e3 
…ule.c` (GH-120588) (#120616)

gh-120586: Fix several "unused function" warnings in `posixmodule.c` (GH-120588)
(cherry picked from commit 3df2022)

Co-authored-by: Nikita Sobolev <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@sobolevn @mrahtz
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
a72b54e 
…le.c` (python#120588)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@sobolevn @noahbkim
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
011c704 
…le.c` (python#120588)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@sobolevn @estyxx
pythongh-120586: Fix several "unused function" warnings in `posixmodu…
ed926bd 
…le.c` (python#120588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn