Skip to content

zipfile.Path.glob fails to match directories #122903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaraco opened this issue Aug 11, 2024 · 0 comments
Closed

zipfile.Path.glob fails to match directories #122903

jaraco opened this issue Aug 11, 2024 · 0 comments
Assignees
@jaraco
Labels
triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error

Comments

@jaraco
Copy link
Member

jaraco commented Aug 11, 2024 •
edited by bedevere-app bot
Loading

As reported in jaraco/zipp#121, the glob logic in zipfile.Path doesn't honor directories.

This issue tracks porting the fix here.

Linked PRs
@jaraco jaraco added type-bug An unexpected behavior, bug, or error triaged The issue has been accepted as valid by a triager. labels Aug 11, 2024
@jaraco jaraco self-assigned this Aug 11, 2024
jaraco added a commit to jaraco/cpython that referenced this issue Aug 11, 2024
@jaraco
pythongh-122903: Honor directories in zipfile.Path.glob.
8386727 
Applies changes from zipp v3.19.2 and v3.19.3 (jaraco/zipp#121).
@jaraco jaraco mentioned this issue Aug 11, 2024
Merged
jaraco added a commit to jaraco/cpython that referenced this issue Aug 11, 2024
@jaraco
pythongh-122903: Honor directories in zipfile.Path.glob.
d561f81 
Applies changes from zipp v3.19.2 and v3.19.3 (jaraco/zipp#121).
jaraco added a commit to jaraco/cpython that referenced this issue Aug 11, 2024
@jaraco
pythongh-122903: Honor directories in zipfile.Path.glob.
7491195 
Applies changes from zipp v3.19.2 and v3.19.3 (jaraco/zipp#121).
jaraco added a commit that referenced this issue Aug 12, 2024
@jaraco
gh-122903: Honor directories in zipfile.Path.glob. (#122908)
6aa35f3
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 12, 2024
@jaraco @miss-islington
pythongh-122903: Honor directories in zipfile.Path.glob. (pythonGH-12…
686818e 
…2908)

(cherry picked from commit 6aa35f3)

Co-authored-by: Jason R. Coombs <[email protected]>
This was referenced Aug 12, 2024
Merged
Merged
jaraco added a commit to jaraco/cpython that referenced this issue Aug 12, 2024
@jaraco
[3.12] pythongh-122903: Honor directories in zipfile.Path.glob. (pyth…
5d9f730 
…onGH-122908)

(cherry picked from commit 6aa35f3)

Co-authored-by: Jason R. Coombs <[email protected]>
jaraco pushed a commit that referenced this issue Aug 12, 2024
@miss-islington
[3.13] gh-122903: Honor directories in zipfile.Path.glob. (GH-122908) (…
59d0d33 
…#122926)

(cherry picked from commit 6aa35f3)
jaraco added a commit that referenced this issue Aug 12, 2024
@jaraco
[3.12] gh-122903: Honor directories in zipfile.Path.glob. (GH-122908) (…
f511a93 
…#122927)

(cherry picked from commit 6aa35f3)
@jaraco jaraco closed this as completed Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@jaraco @blhsing
pythongh-122903: Honor directories in zipfile.Path.glob. (python#122908)
2ddd5a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaraco jaraco

Labels
triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco