Notes comparing NotImplementedError and NotImplemented have inconsistent linking

[nexushoratio]

Documentation

The link to the OtherItem is in different locations in the otherwise similar notes. One with the See OtherItem, the other in the sentence calling out they are different. They should probably be consistent.

I personally think they should be like in constants, with the See OtherItem sentence.

constants.html reads:

Note: NotImplementedError and NotImplemented are not interchangeable, even though they have similar names and purposes. See NotImplementedError for details on when to use it.

exceptions.html reads:

Note: NotImplementedError and NotImplemented are not interchangeable, even though they have similar names and purposes. See NotImplemented for details on when to use it.

cpython/Doc/library/constants.rst

Lines 51 to 53 in 5aaf416

	``NotImplementedError`` and :data:`!NotImplemented` are not interchangeable,
	even though they have similar names and purposes.
	See :exc:`NotImplementedError` for details on when to use it.

cpython/Doc/library/exceptions.rst

Lines 338 to 340 in 5aaf416

	``NotImplementedError`` and :data:`NotImplemented` are not interchangeable,
	even though they have similar names and purposes. See
	:data:`!NotImplemented` for details on when to use it.

I don't know RST. Is it simply moving the ! in exceptions from line 340 to line 338?

Linked PRs

• gh-129015: Move link supression around in a Note for exceptions.rst #129562
• [3.13] gh-129015: Improve disambiguation between NotImplemented and NotImplementedError (GH-129562) #130776
• [3.12] gh-129015: Improve disambiguation between NotImplemented and NotImplementedError (GH-129562) #130777

[picnixz]

I guess it'd be better to have the link when we say "See ..." so yes you just need to move "!". The "!" is a special Sphinx (not reST) markup to suppress a link but keep the semantic usage of the role (data or exc in this case). It can also be used for known broken links (that could be non-broken in the future) while retaining a literal markup.

Would you mind creating a PR for that?

[picnixz]

Thank you for the initial work @nexushoratio!