Skip to content

Speed up sqlite3.Row #129926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erlend-aasland opened this issue Feb 10, 2025 · 0 comments · May be fixed by #129927
Open

Speed up sqlite3.Row #129926

erlend-aasland opened this issue Feb 10, 2025 · 0 comments · May be fixed by #129927
Assignees
@erlend-aasland
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage topic-sqlite3 type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 10, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

We can speed up sqlite.Row subscripting a bit:

  • in pysqlite_row_subscript, after finding the correct index, use fast tuple API to access data
  • in equal_ignore_case, we can simply assert that we are given two unicode objects

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@erlend-aasland erlend-aasland added performance Performance or resource usage topic-sqlite3 type-feature A feature request or enhancement labels Feb 10, 2025
@erlend-aasland erlend-aasland self-assigned this Feb 10, 2025
@bedevere-app bedevere-app bot linked a pull request Feb 10, 2025 that will close this issue
Open
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Feb 10, 2025
@erlend-aasland
pythongh-129926: Speed up sqlite3.Row item access
ee98f2a
@erlend-aasland erlend-aasland linked a pull request Feb 10, 2025 that will close this issue
gh-129926: Speed up sqlite3.Row item access #129927
Open
@picnixz picnixz added the extension-modules C modules in the Modules dir label Feb 10, 2025
@ezio-melotti ezio-melotti mentioned this issue May 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
extension-modules C modules in the Modules dir performance Performance or resource usage topic-sqlite3 type-feature A feature request or enhancement
Projects
sqlite3 issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-129926: Speed up sqlite3.Row item access erlend-aasland/cpython
3 participants
@picnixz @erlend-aasland @ezio-melotti