Suggestion messages don't properly work in nested getattr calls

[pablogsal]

BPO	46940
Nosy	@pfmoore, @vstinner, @tjguk, @ezio-melotti, @zware, @zooba, @pablogsal
PRs	bpo-46940: Don't override existing AttributeError suggestion information #31710 [3.10] bpo-46940: Don't override existing AttributeError suggestion information (GH-31710) #31724
Files	LogDebug.vb

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/pablogsal'
closed_at = <Date 2022-03-07.13:18:53.909>
created_at = <Date 2022-03-06.20:14:41.195>
labels = ['expert-2to3', '3.10', 'performance', 'extension-modules', 'expert-C-API', 'expert-unicode', 'expert-SSL', 'expert-installation', 'expert-IO', '3.11', 'OS-windows']
title = "Suggestion messages don't properly work in nested getattr calls"
updated_at = <Date 2022-03-13.12:08:30.739>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2022-03-13.12:08:30.739>
actor = 'zarayoumi3'
assignee = 'pablogsal'
closed = True
closed_date = <Date 2022-03-07.13:18:53.909>
closer = 'pablogsal'
components = ['Extension Modules', 'Installation', 'Unicode', 'Windows', '2to3 (2.x to 3.x conversion tool)', 'IO', 'SSL', 'C API']
creation = <Date 2022-03-06.20:14:41.195>
creator = 'pablogsal'
dependencies = []
files = ['50670']
hgrepos = []
issue_num = 46940
keywords = ['patch']
message_count = 3.0
messages = ['414623', '414661', '414666']
nosy_count = 8.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'ezio.melotti', 'zach.ware', 'steve.dower', 'pablogsal', 'zarayoumi3']
pr_nums = ['31710', '31724']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue46940'
versions = ['Python 3.10', 'Python 3.11']

[pablogsal]

Consider this code:

class A:
    __slots__ = [
        "_color",
    ]

    color = None

    @property
    def color(self):
        return self._color

A().color

Executing this shows:

Traceback (most recent call last):
  File "/Users/pgalindo3/lel.py", line 21, in <module>
    A().color
  File "/Users/pgalindo3/lel.py", line 18, in color
    return self._color
AttributeError: 'A' object has no attribute '_color'. Did you mean: '_color'?

This is because the nested getattr call of "@Property" overrides the metadata information in the exception object and it tries to produce an error message for the attribute "color" instead of "_color".

[pablogsal]

New changeset 3b3be05 by Pablo Galindo Salgado in branch 'main':
bpo-46940: Don't override existing AttributeError suggestion information (GH-31710)
3b3be05

[pablogsal]

New changeset 3594ebc by Pablo Galindo Salgado in branch '3.10':
[3.10] bpo-46940: Don't override existing AttributeError suggestion information (GH-31710) (GH-31724)
3594ebc