Skip to content

Doc on weakref.proxy should mention ReferenceError #98348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fancidev opened this issue Oct 17, 2022 · 3 comments
Closed

Doc on weakref.proxy should mention ReferenceError #98348

fancidev opened this issue Oct 17, 2022 · 3 comments
Labels
docs Documentation in the Doc dir

Comments

@fancidev
Copy link
Contributor

The documentation on weakref.proxy does not say what happens if an attribute of the proxy object is accessed when the referent is gone. I had to do a bit of googling to find out it raises ReferenceError.

Would be helpful to mention that in the doc of weakref.proxy.
@fancidev fancidev added the docs Documentation in the Doc dir label Oct 17, 2022
@sobolevn
Copy link
Member

@fancidev are you willing to send a PR? :)

@bedevere-bot bedevere-bot mentioned this issue Oct 17, 2022
Merged
@fancidev
Copy link
Contributor Author

Here you go!

JelleZijlstra pushed a commit that referenced this issue Oct 26, 2022
@fancidev
gh-98348: Mention ReferenceError in weakref.proxy documentation (#98355)
216f45e
@bedevere-bot bedevere-bot mentioned this issue Oct 26, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 26, 2022
@fancidev @miss-islington
pythongh-98348: Mention ReferenceError in weakref.proxy documentation (…
24a206e 
…pythonGH-98355)

(cherry picked from commit 216f45e)

Co-authored-by: fancidev <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 26, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 26, 2022
@fancidev @miss-islington
pythongh-98348: Mention ReferenceError in weakref.proxy documentation (…
418dd8d 
…pythonGH-98355)

(cherry picked from commit 216f45e)

Co-authored-by: fancidev <[email protected]>
miss-islington added a commit that referenced this issue Oct 26, 2022
@miss-islington @fancidev
gh-98348: Mention ReferenceError in weakref.proxy documentation (GH-9…
5e08585 
…8355)

(cherry picked from commit 216f45e)

Co-authored-by: fancidev <[email protected]>
miss-islington added a commit that referenced this issue Oct 26, 2022
@miss-islington @fancidev
gh-98348: Mention ReferenceError in weakref.proxy documentation (GH-9…
2aedba5 
…8355)

(cherry picked from commit 216f45e)

Co-authored-by: fancidev <[email protected]>
@hauntsaninja
Copy link
Contributor

Thanks, looks like this was completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @fancidev @hauntsaninja