Skip to content

[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary #101316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary #101316

wants to merge 5 commits into from

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jan 25, 2023 •
edited by bedevere-bot
Loading

This a backport of #101013 in principle, although the mechanism for determining when to skip the call to throw() is different.

@markshannon markshannon added the 3.11 only security fixes label Jan 25, 2023
@markshannon markshannon requested a review from 1st1 as a code owner January 25, 2023 11:16
@markshannon markshannon changed the title [3.11] Don't call gen.throw() in gen.close(), unless necessary [3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary Jan 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 25, 2023
Closed
brandtbucher
brandtbucher reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to do this? The code looks fine to me... I'm not sure why the tests are failing, but it definitely seems related.

@markshannon
Copy link
Member Author

Given 3.13 will be released soon and this is working in 3.12, I don't think it is worth investigating further why this doesn't work.

@markshannon markshannon deleted the 100762-backport branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
3.11 only security fixes awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @brandtbucher @bedevere-bot