Skip to content

Docs: fix typos in PyFunction_WatchCallback docs and in 3.12 NEWS #101980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

Docs: fix typos in PyFunction_WatchCallback docs and in 3.12 NEWS #101980

merged 2 commits into from
Feb 17, 2023

Conversation

yeojin-dev
Copy link
Contributor

@yeojin-dev yeojin-dev commented Feb 17, 2023 •
edited by erlend-aasland
Loading

  • possitibility => possibility
  • disaallowed => disallowed

@bedevere-bot

This comment was marked as outdated.

Sign in to view
@ghost
Copy link

ghost commented Feb 17, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev added docs Documentation in the Doc dir skip issue skip news labels Feb 17, 2023
@erlend-aasland erlend-aasland changed the title Fix typo Docs: fix types in PyFunction_WatchCallback docs and in 3.12 NEWS Feb 17, 2023
@erlend-aasland erlend-aasland changed the title Docs: fix types in PyFunction_WatchCallback docs and in 3.12 NEWS Docs: fix typos in PyFunction_WatchCallback docs and in 3.12 NEWS Feb 17, 2023
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 3c0a31c into python:main Feb 17, 2023
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 17, 2023
@miss-islington
Copy link
Contributor

Thanks @yeojin-dev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @yeojin-dev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @yeojin-dev, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3c0a31cbfd1258bd96153a007dd44a96f2947dbf 3.10

@miss-islington miss-islington self-assigned this Feb 17, 2023
@miss-islington
Copy link
Contributor

Sorry @yeojin-dev, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 3c0a31cbfd1258bd96153a007dd44a96f2947dbf 3.11

@erlend-aasland erlend-aasland removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 17, 2023
@erlend-aasland
Copy link
Contributor

Backporting does not make sense: there's no 3.12 news in the other branches, and the API mentioned was only recently introduced.

Thanks for the fix, @yeojin-dev !

@yeojin-dev yeojin-dev deleted the fix-typo branch February 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@isidentical isidentical Awaiting requested review from isidentical

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yeojin-dev @bedevere-bot @miss-islington @erlend-aasland @arhadthedev