gh-88233: zipfile: refactor _strip_extra #102083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any data _after_ the zip64 extra would be removed. With many new tests. Fixes python#88233
…hon#102046) This PR updates the cmath module documentation to reflect the reality that Python is almost always (and as far as I can tell, that "almost" can be omitted) running on a machine whose C double supports signed zeros. * Removes misleading references to functions being continuous from above / below / the left / the right at branch cuts * Expands the note on branch cuts at the top of the module documentation to explain the double-sided sign-of-zero-based behaviour
…1962) Co-authored-by: C.A.M. Gerlach <[email protected]>
Fixes compiler warnings in pytime.c.
…-102070) Automerge-Triggered-By: GH:erlend-aasland
…onGH-101912) * pythongh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h * Make cases_generator correct on Windows
…tras instead of a heavy-state loop.
jaraco
requested review from
pganssle,
abalkin,
markshannon,
iritkatriel and
ezio-melotti
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyErr_SetObject()behavior is strange and not as documented. #101578: Amend PyErr_{Set,Get}RaisedException docs (gh-101578: Amend PyErr_{Set,Get}RaisedException docs #101962)_Py_InIntegralTypeRange#97786: Fix compiler warnings in pytime.c (gh-97786: Fix compiler warnings in pytime.c #101826)_ioextension module #101819: Adapt _io types to heap types, batch 1 (gh-101819: Adapt _io types to heap types, batch 1 #101949)_Py_OPCODEand_Py_OPARGmacros (gh-101907: Stop using_Py_OPCODEand_Py_OPARGmacros #101912)