Skip to content

Gh-68586: use run_python_until_end in test_capi #102729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2023
Merged

Gh-68586: use run_python_until_end in test_capi #102729

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2aaf8d
Gh-68586: use run_python_until_end in test_capi
furkanonder Mar 15, 2023
6979a6f
Fix failed testcase
furkanonder Apr 2, 2023
1c9c589
Update Lib/test/test_capi/test_misc.py
kumaraditya303 Apr 9, 2023
3df33dc
Merge branch 'main' into issue-68586
kumaraditya303 Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from test.support import import_helper
from test.support import threading_helper
from test.support import warnings_helper
from test.support.script_helper import assert_python_failure, assert_python_ok
from test.support.script_helper import assert_python_failure, assert_python_ok, run_python_until_end
try:
import _posixsubprocess
except ImportError:
Expand Down Expand Up @@ -69,21 +69,17 @@ def test_instancemethod(self):

@support.requires_subprocess()
def test_no_FatalError_infinite_loop(self):
with support.SuppressCrashReport():
p = subprocess.Popen([sys.executable, "-c",
'import _testcapi;'
'_testcapi.crash_no_current_thread()'],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True)
(out, err) = p.communicate()
self.assertEqual(out, '')
run_result, _cmd_line = run_python_until_end(
'-c', 'import _testcapi; _testcapi.crash_no_current_thread()',
)
_rc, out, err = run_result
self.assertEqual(out, b'')
# This used to cause an infinite loop.
msg = ("Fatal Python error: PyThreadState_Get: "
"the function must be called with the GIL held, "
"after Python initialization and before Python finalization, "
"but the GIL is released "
"(the current Python thread state is NULL)")
"(the current Python thread state is NULL)").encode()
self.assertTrue(err.rstrip().startswith(msg),
err)

Expand Down