Skip to content

gh-102828: set stacklevel on deprecation warning #103422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 10, 2023

@iritkatriel iritkatriel added skip news 3.12 only security fixes labels Apr 10, 2023
@iritkatriel iritkatriel changed the title gh-102850: set stacklevel on deprecation warning gh-102828: set stacklevel on deprecation warning Apr 10, 2023
@iritkatriel
Copy link
Member Author

CC @davidism.

@iritkatriel iritkatriel merged commit 8026cda into python:main Apr 11, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 8026cda.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3671) and take a look at the build logs.
  4. Check if the failure is related to this commit (8026cda) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3671

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_venv: 7 min 9 sec
  • test_asyncio: 6 min 32 sec
  • test_largefile: 5 min 18 sec
  • test_multiprocessing_spawn: 4 min 28 sec
  • test_multiprocessing_main_handling: 4 min 15 sec
  • test_math: 4 min 12 sec
  • test_concurrent_futures: 3 min 7 sec
  • test_shelve: 2 min 47 sec
  • test_zipfile: 2 min 41 sec
  • test_tokenize: 2 min 30 sec

1 test altered the execution environment:
test_multiprocessing_spawn

20 tests skipped:
test_devpoll test_idle test_ioctl test_kqueue test_launcher
test_msilib test_peg_generator test_perf_profiler test_startfile
test_tcl test_tix test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 33 min 7 sec

Click to see traceback logs
remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 4 (delta 3), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '8026cda10ccd3cbc7f7ff84dc6970266512961e4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8026cda10c gh-102828: set stacklevel on deprecation warning (#103422)
Switched to and reset branch 'main'

Objects/obmalloc.c:775:1: warning: ‘always_inline’ function might not be inlinable [-Wattributes]
  775 | arena_map_get(pymem_block *p, int create)
      | ^~~~~~~~~~~~~

make: *** [Makefile:1947: buildbottest] Error 3

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@iritkatriel iritkatriel deleted the stacklevel2 branch July 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 only security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants