Skip to content

gh-103291: Re-activate virtual environments in child processes #103447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-103291: Re-activate virtual environments in child processes #103447

wants to merge 2 commits into from

Conversation

nakulj
Copy link

@nakulj nakulj commented Apr 11, 2023

In child processes, virtual environments are 'activated' by exported variables, but can't be deactivated correctly. This change re-activates environments if necessary.

@nakulj nakulj requested a review from vsajip as a code owner April 11, 2023 17:51
@ghost
Copy link

ghost commented Apr 11, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Apr 11, 2023
@arhadthedev arhadthedev changed the title Re-activate virtual environments in child processes gh-103291: Re-activate virtual environments in child processes Apr 11, 2023
@nakulj nakulj marked this pull request as draft April 11, 2023 21:34
@nakulj
Copy link
Author

nakulj commented Apr 11, 2023

Derp I just realized that the defined function isn't actually called in the child process. Let me think about this a little more.

@nakulj nakulj closed this by deleting the head repository Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants