gh-101786: Clarify docs that asyncio.Server.sockets is a socket-like TransportSocket #103877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willingc
commented
Apr 26, 2023
•
willingc
commented
- Issue: Incorrect / incomplete documentation of asyncio.Server #101786
willingc
requested review from
1st1,
asvetlov,
gvanrossum and
kumaraditya303
as code owners
itamaro
pushed a commit
to itamaro/cpython
that referenced
this pull request
Apr 26, 2023
…-like TransportSocket (python#103877) Clarify that asyncio.Server.sockets is a socket-like TransportSocket
|
Thanks @willingc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @willingc, I had trouble checking out the |
|
GH-103890 is a backport of this pull request to the 3.11 branch. |
hauntsaninja
pushed a commit
to hauntsaninja/cpython
that referenced
this pull request
Apr 26, 2023
… socket-like TransportSocket (pythonGH-103877) Clarify that asyncio.Server.sockets is a socket-like TransportSocket (cherry picked from commit 1c0a9c5) Co-authored-by: Carol Willing <[email protected]>
hauntsaninja
added a commit
that referenced
this pull request
Apr 26, 2023
…t-like TransportSocket (GH-103877) (#103890) Clarify that asyncio.Server.sockets is a socket-like TransportSocket (cherry picked from commit 1c0a9c5) Co-authored-by: Carol Willing <[email protected]>
|
Thanks all, I took care of the backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.