Skip to content

[3.11] gh-98822: Add missing test directories to TESTSUBDIRS (#103942) #103946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

[3.11] gh-98822: Add missing test directories to TESTSUBDIRS (#103942) #103946

merged 1 commit into from
Apr 27, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from zware April 27, 2023 19:54
This was referenced Apr 27, 2023
Closed
Merged
@erlend-aasland erlend-aasland enabled auto-merge (squash) April 27, 2023 19:56
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Zach. I trust the CI to wait for the macOS check 🤖 😄

@zware
Copy link
Member

zware commented Apr 27, 2023 •
edited
Loading

I'm not sure it will: apparently macOS isn't required on main :)

Edit: but it is on 3.11, so that's irrelevant here 🤦‍♂️. Automerge should in fact wait here, but probably (not sure we've tested it yet?) wouldn't have in the main PR.

@erlend-aasland erlend-aasland merged commit 838bc90 into python:3.11 Apr 27, 2023
@erlend-aasland erlend-aasland deleted the 3.11-testsubdirs branch April 27, 2023 20:35
@ned-deily
Copy link
Member

ned-deily commented Apr 27, 2023 •
edited
Loading

I will explicitly test this on both main and 3.11 on macOS. I just noticed on Tuesday at the sprint just before I left that no sqlite tests seemed to be running when using an installed Python and was going to investigate that next; I suspected it would turn out to be something like this.

@zware zware mentioned this pull request Apr 28, 2023
Merged
zware added a commit to zware/cpython that referenced this pull request Apr 28, 2023
@zware
[3.11] pythongh-98822: Correct a few TESTSUBDIRS entries
0f2cefc 
A few differences from the main branch were missed in pythonGH-103946.
zware added a commit that referenced this pull request Apr 28, 2023
@zware
[3.11] gh-98822: Correct a few TESTSUBDIRS entries (GH-103970)
4219074 
A few differences from the main branch were missed in GH-103946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @zware @ned-deily @bedevere-bot