Skip to content

Update Windows library names for the Python version bump #104755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 22, 2023

Seems that's somehow missed

@Eclips4 Eclips4 requested a review from a team as a code owner May 22, 2023 19:39
@Eclips4
Copy link
Member Author

Eclips4 commented May 22, 2023

cc @Yhg1s

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyconfig.h changes look good to me. I think the configure changes are fine, but I so rarely touch that script that someone else should check it too.

@arhadthedev
Copy link
Member

Probably, automation of these changes should also be added into https://github.com/python/release-tools.

@Eclips4
Copy link
Member Author

Eclips4 commented May 22, 2023

Also, there's a problem with test_enum, but this should be a seperate issue/PR

@Eclips4 Eclips4 changed the title Fix old version Fix old version and some stuff May 22, 2023
@Yhg1s Yhg1s changed the title Fix old version and some stuff Update Windows library names for the Python version bump May 22, 2023
@Yhg1s
Copy link
Member

Yhg1s commented May 22, 2023

The configure script is being taken care of in #104757, so that can be dropped from this PR.

@Eclips4
Copy link
Member Author

Eclips4 commented May 22, 2023

The configure script is being taken care of in #104757, so that can be dropped from this PR.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants