Skip to content

[3.12] Enable the ABI check job to publish the expected ABI data #105088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2023
Merged

[3.12] Enable the ABI check job to publish the expected ABI data #105088

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83b6e40
Enable the ABI check job to publish the expected ABI data
zooba May 30, 2023
ea1d770
Simulating a failure - will revert this before merging!
zooba May 30, 2023
74f759d
Try a different simulated failure
zooba May 30, 2023
d24da92
Revert simulated breakage
zooba May 30, 2023
9860e80
Filter published file and add simulated breakage
zooba May 30, 2023
05b0606
Improved message and more drastic breakage for testing
zooba May 30, 2023
1cfe7f7
Update ABI data from build
zooba May 30, 2023
ab50ca0
Merge remote-tracking branch 'cpython/3.12' into abiupdates-3.12
zooba May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,28 @@ jobs:
./configure --enable-shared
make -j4
- name: Check for changes in the ABI
id: check
run: |
if ! make check-abidump; then
echo "Generated ABI file is not up to date."
echo "Please add the release manager of this branch as a reviewer of this PR."
echo ""
echo "The up to date ABI file should be attached to this build as an artifact."
echo ""
echo "To learn more about this check: https://devguide.python.org/setup/#regenerate-the-abi-dump"
echo ""
exit 1
fi
- name: Generate updated ABI files
if: ${{ failure() && steps.check.conclusion == 'failure' }}
run: |
make regen-abidump
- uses: actions/upload-artifact@v3
name: Publish updated ABI files
if: ${{ failure() && steps.check.conclusion == 'failure' }}
with:
name: abi-data
path: ./Doc/data/*.abi

check_generated_files:
name: 'Check if generated files are up to date'
Expand Down