Skip to content

gh-105089: Fix test_create_directory_with_write test failure in AIX #105228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2024
Merged

gh-105089: Fix test_create_directory_with_write test failure in AIX #105228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af6655e
pythongh-105089: Fix test_create_directory_with_write failure in AIX
ayappanec Jun 2, 2023
ba8e302
Add NEWS entry
ayappanec Jun 2, 2023
c8ac8d2
Merge branch 'main' into gh-105089
ayappanec Sep 7, 2023
d84db02
Merge branch 'main' into gh-105089
serhiy-storchaka Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_zipfile/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,7 +2959,7 @@ def test_create_directory_with_write(self):

directory = os.path.join(TESTFN2, "directory2")
os.mkdir(directory)
mode = os.stat(directory).st_mode
mode = os.stat(directory).st_mode & 0xFFFF
zf.write(directory, arcname="directory2/")
zinfo = zf.filelist[1]
self.assertEqual(zinfo.filename, "directory2/")
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Tests/2023-06-02-05-04-15.gh-issue-105089.KaZFtU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix
``test.test_zipfile.test_core.TestWithDirectory.test_create_directory_with_write``
test in AIX by doing a bitwise AND of 0xFFFF on mode , so that it will be in
sync with ``zinfo.external_attr``