Skip to content

gh-105375: Improve errnomodule error handling #105590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the improve-errno-error-handling branch June 9, 2023 19:57
@miss-islington
Copy link
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker eede1d2f48b4fe7f7918952d9ebeb744b58668c1 3.12

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eede1d2f48b4fe7f7918952d9ebeb744b58668c1 3.11

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
…5590)

(cherry picked from commit eede1d2)

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
…5590)

(cherry picked from commit eede1d2)

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot
Copy link

GH-105595 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

GH-105596 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@erlend-aasland erlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
18 tasks
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
(cherry picked from commit eede1d2)

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
(cherry picked from commit eede1d2)

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions
3 participants