Skip to content

gh-105196: Fix indentations of section headings in C API docs #105672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

gh-105196: Fix indentations of section headings in C API docs #105672

merged 1 commit into from
Jun 14, 2023

Conversation

roy9495
Copy link
Contributor

@roy9495 roy9495 commented Jun 12, 2023 •
edited by CAM-Gerlach
Loading

Changes Made:

  • In the C-api documentation index, Pack Functions and Unpack Functions are indented under Pack and Unpack Functions
  • In the C-api documentation index, Ellipsis Object is indented under Slice Objects
  • In the C-api documentation index, Internal Frames is indented under Frame Objects

Thank you

📚 Documentation preview 📚: https://cpython-previews--105672.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@roy9495 roy9495 changed the title Indentations of c-api documentation index fixed gh-105196: Indentations of c-api documentation index fixed Jun 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
Closed
@roy9495 roy9495 force-pushed the issue#105196/roy9495 branch from a644ac4 to e31060f Compare June 12, 2023 06:12
@arhadthedev
Copy link
Member

@iritkatriel as an author of the parent issue.

@CAM-Gerlach CAM-Gerlach changed the title gh-105196: Indentations of c-api documentation index fixed gh-105196: Fix indentations of sections headings in C API docs Jun 14, 2023
@CAM-Gerlach CAM-Gerlach changed the title gh-105196: Fix indentations of sections headings in C API docs gh-105196: Fix indentations of section headings in C API docs Jun 14, 2023
@CAM-Gerlach CAM-Gerlach added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 14, 2023
CAM-Gerlach
CAM-Gerlach approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @roy9495

@CAM-Gerlach CAM-Gerlach requested a review from iritkatriel June 14, 2023 06:23
iritkatriel
iritkatriel approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iritkatriel iritkatriel merged commit d32e8d6 into python:main Jun 14, 2023
@miss-islington
Copy link
Contributor

Thanks @roy9495 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @roy9495 and @iritkatriel, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d32e8d6070057eb7ad0eb2f9d9f1efab38b2cff4 3.12

@miss-islington
Copy link
Contributor

Sorry, @roy9495 and @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d32e8d6070057eb7ad0eb2f9d9f1efab38b2cff4 3.11

@iritkatriel iritkatriel added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 14, 2023
@miss-islington
Copy link
Contributor

Thanks @roy9495 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @roy9495 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @roy9495 and @iritkatriel, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d32e8d6070057eb7ad0eb2f9d9f1efab38b2cff4 3.11

@bedevere-bot
Copy link

GH-105782 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2023
@roy9495 @miss-islington
pythongh-105196: Fix indentations of section headings in C API docs (p…
292b20f 
…ythonGH-105672)

(cherry picked from commit d32e8d6)

Co-authored-by: TATHAGATA ROY <[email protected]>
@iritkatriel iritkatriel added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 14, 2023
@miss-islington
Copy link
Contributor

Thanks @roy9495 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @roy9495 and @iritkatriel, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d32e8d6070057eb7ad0eb2f9d9f1efab38b2cff4 3.11

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Jun 14, 2023
@roy9495 @iritkatriel
pythongh-105196: Fix indentations of section headings in C API docs (p…
306e310 
…ython#105672)
@iritkatriel iritkatriel mentioned this pull request Jun 14, 2023
Merged
@bedevere-bot
Copy link

GH-105786 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 14, 2023
CAM-Gerlach pushed a commit that referenced this pull request Jun 15, 2023
@miss-islington @roy9495
[3.12] gh-105196: Fix indentations of section headings in C API docs (G…
335fbd6 
…H-105672) (#105782)

gh-105196: Fix indentations of section headings in C API docs (GH-105672)
(cherry picked from commit d32e8d6)

Co-authored-by: TATHAGATA ROY <[email protected]>
CAM-Gerlach pushed a commit that referenced this pull request Jun 15, 2023
@iritkatriel @roy9495
[3.11] gh-105196: Fix indentations of section headings in C API docs (#…
e422f35 
…105672) (#105786)

gh-105196: Fix indentations of section headings in C API docs (#105672)

Co-authored-by: TATHAGATA ROY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@iritkatriel iritkatriel

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roy9495 @arhadthedev @miss-islington @bedevere-bot @iritkatriel @CAM-Gerlach