GH-105678: Split MAKE_FUNCTION into MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE #105680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan,
warsaw and
iritkatriel
as code owners
markshannon
commented
Jun 12, 2023
| @@ -463,7 +465,7 @@ def _write_atomic(path, data, mode=0o666): | |||
| # Whenever MAGIC_NUMBER is changed, the ranges in the magic_values array | |||
| # in PC/launcher.c must also be updated. | |||
|
|
|||
| MAGIC_NUMBER = (3551).to_bytes(2, 'little') + b'\r\n' | |||
| MAGIC_NUMBER = (3554).to_bytes(2, 'little') + b'\r\n' | |||
There was a problem hiding this comment.
I'll set this to the correct value before merging.
The actual number will depend on which PRs get merged first.
carljm
approved these changes
Jun 12, 2023
|
Once we handle closures in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to simplify the stack effect of
MAKE_FUNCTIONto simplify our code generators and analysis.This probably isn't the final version of
MAKE_FUNCTION.I expect that will take a variable number of cells, embedding the cells directly in the function object to avoid the indirection in accessing cells.
I've kept the same flags as before.
SET_FUNCTION_ATTRIBUTEcould be streamlined, but that's for another PR.