-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-102450: Add ISO-8601 alternative for midnight to fromisoformat()
calls.
#105856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e57d1b6
Add NEWS.d entry
TizzySaurus 9613a38
Merge branch 'main' of personal.github.com:TizzySaurus/cpython
TizzySaurus aa67832
Merge remote-tracking branch 'upstream/main'
TizzySaurus d711daf
Allow ISO-8601 24:00 alternative to midnight on datetime.time.fromiso…
TizzySaurus f32aa97
Allow ISO-8601 24:00 alternative to midnight on datetime.datetime.fro…
TizzySaurus d52bf41
Add NEWS.d entry
TizzySaurus 699dfcb
Improve error message when hour is 24 and minute/second/microsecond i…
TizzySaurus 6e46433
Add tests for 24:00 fromisoformat
TizzySaurus 040da2c
Remove duplicate call to days_in_month() by storing in variable
TizzySaurus 4833d68
Add Python implementation
TizzySaurus c71764f
Fix Lint
TizzySaurus 0b92a1c
Fix differing error msg in datetime.fromisoformat implementations whe…
TizzySaurus c9db98b
Fix using time components inside tzinfo in Python implementation
TizzySaurus 004a5ff
Don't parse tzinfo in C implementation when invalid iso midnight
TizzySaurus f182e2e
Remove duplicated variable in datetime test assertion line
TizzySaurus 1b65671
Add self to acknowledgements
TizzySaurus ae85372
Remove duplicate NEWS entry
TizzySaurus 9d02f82
Linting
TizzySaurus 2ccb2a2
Add missing test case for when wrapping the year makes it invalid (to…
TizzySaurus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2023-06-16-14-52-00.gh-issue-102450.MfeR6A.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Add missing ISO-8601 24:00 alternative to midnight of next day to :meth:`datetime.datetime.fromisoformat` and :meth:`datetime.time.fromisoformat`. | ||
Patch by Izan "TizzySaurus" Robinson ([email protected]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.