gh-105873: Make _xxsubinterpreters use exception type name in shared exception
#105874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d exception * changed format specifier in `PyUnicode_FromFormat` call to accept raw string, pass `tp_name` of exception as second argument * fixed test
chgnrdv
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
@ericsnowcurrently any reason you chose to hold off on merging? |
|
I'm mostly unavailable for the next couple weeks. |
kumaraditya303
approved these changes
Jul 8, 2023
|
Thanks @kumaraditya303! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105873
PyUnicode_FromFormatcall to accept raw string, passtp_nameof exception as second argument_xxsubinterpreters: the name of shared exception type isstr(exc_type), notexc_type.__name__#105873