gh-106603: Make uop struct a triple (opcode, oparg, operand) #106794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
commented
Jul 15, 2023
Comment on lines
-652
to
+655
| inst(STORE_SUBSCR, (counter/1, v, container, sub -- )) { | ||
| inst(STORE_SUBSCR, (unused/1, v, container, sub -- )) { | ||
| #if ENABLE_SPECIALIZATION | ||
| if (ADAPTIVE_COUNTER_IS_ZERO(counter)) { | ||
| _PyStoreSubscrCache *cache = (_PyStoreSubscrCache *)next_instr; | ||
| if (ADAPTIVE_COUNTER_IS_ZERO(cache->counter)) { |
There was a problem hiding this comment.
This change simply follows the vast majority of other unspecialized opcodes.
|
@markshannon Can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost everything that used to go in operand now goes in oparg, except cache entries, which go into operand. This way a uop can have an oparg and a cache entry, which is much more convenient for splitting the more complex CALL specializations into uops. Most of the complexity (and debugging :-( ) went into optimizer.c.
As a side effect, without any extra work, we have four new viable uops:
The Python API (iterating over a uop executor) now returns triples (opname, oparg, operand).