Skip to content

[3.12] GH-106897: Add RERAISE event to sys.monitoring. (GH-107291) #107346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 27, 2023

Manual backport of GH-107291.

@Yhg1s as release manager.

Fixes an omission in PEP 669, resulting in an imbalance between raise and unwind/handle events for exceptions.

…07291)

* Ensures that exception handling events are balanced. Each [re]raise event has a matching unwind/handled event.
@markshannon markshannon changed the title GH-106897: Add RERAISE event to sys.monitoring. (GH-107291) [3.12] GH-106897: Add RERAISE event to sys.monitoring. (GH-107291) Jul 27, 2023
@markshannon
Copy link
Member Author

The ABI checking tool claims that the ABI has changed.
Why is the internal layout of PyInterpreterState part of the ABI?

@Yhg1s
Copy link
Member

Yhg1s commented Jul 27, 2023

The ABI checking tool claims that the ABI has changed. Why is the internal layout of PyInterpreterState part of the ABI?

Because it's reachable through symbols exposed in the ABI. The ABI checking tool is not tightly constrained, and errs on the side of caution. (I'm sure we'd all be happy if you wanted to spend some time creating an accurate checking tool with no false negatives and fewer false positives :)

@markshannon
Copy link
Member Author

The ABI file diff is a quite a lot larger than I would have liked, but it seems to be OK.
@Yhg1s are you OK with merging the updated ABI file?

@markshannon
Copy link
Member Author

I've waded through the Doc/data/python3.12.abi diff, and the changes are as expected, plus a lot of line number changes and some reordering.

@markshannon markshannon merged commit 3b1a4c1 into python:3.12 Jul 28, 2023
@markshannon markshannon deleted the backport-107291 branch July 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants