Skip to content

gh-107461 ctypes: Add a testcase for nested _as_parameter_ lookup #107462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 30, 2023

Adds a testcase for a nested lookup of the _as_parameter_ attribute when converting a custom object to a ctypes type.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 1, 2024
@serhiy-storchaka serhiy-storchaka merged commit 0bf42da into python:main Feb 1, 2024
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2024

GH-114858 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 1, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2024

GH-114859 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 1, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 1, 2024
…ookup (GH-107462) (GH-114858)

(cherry picked from commit 0bf42da)

Co-authored-by: Tomas R <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Feb 1, 2024
…ookup (GH-107462) (GH-114859)

(cherry picked from commit 0bf42da)

Co-authored-by: Tomas R <[email protected]>
@tomasr8 tomasr8 deleted the nested-as-parameter branch February 1, 2024 12:48
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants