gh-107959: clarify Unix-availability of os.lchmod()
#107960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calestyo
force-pushed
the
improve-lchmod-docs
branch
2 times, most recently
from
1bd9fff to
dc0025a
Compare
|
Well... I guess that comes out when one has apparently no deep knowledge of rst syntax and was too lazy to install all build dependencies ^^ Any idea how one properly adds some comment to the availability? |
|
Ah that’s not how the directive is designed! The value must be Process detail: please don’t use force pushes for Python PRs, it makes it harder to see changes over time, and github creates notifications with non-working links for reviewers. PRs are always squash merged in the end so there is no need to rewrite history for a PR. See https://devguide.python.org/getting-started/pull-request-lifecycle/index.html |
merwok
added
needs backport to 3.11
AA-Turner
reviewed
Aug 15, 2023
POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. Co-authored-by: Adam Turner <[email protected]> Signed-off-by: Christoph Anton Mitterer <[email protected]>
calestyo
force-pushed
the
improve-lchmod-docs
branch
from
f3c2508 to
47a799c
Compare
|
Sorry for another force push... but that all became to messy to me and I had rebased my branch to The new single commit should include the suggested |
merwok
reviewed
Aug 15, 2023
merwok
reviewed
Aug 15, 2023
serhiy-storchaka
approved these changes
Dec 13, 2023
|
Thanks @calestyo for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-113066 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 13, 2023
…-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. (cherry picked from commit f14e3d5) Co-authored-by: Christoph Anton Mitterer <[email protected]> Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 13, 2023
…-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. (cherry picked from commit f14e3d5) Co-authored-by: Christoph Anton Mitterer <[email protected]> Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
GH-113067 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 13, 2023
…) (GH-113066) gh-107959: clarify Unix-availability of `os.lchmod()` (GH-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. (cherry picked from commit f14e3d5) Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 13, 2023
…) (GH-113067) gh-107959: clarify Unix-availability of `os.lchmod()` (GH-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. (cherry picked from commit f14e3d5) Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…-107960) POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so. Consequently, `lchmod()` is not part of POSIX (but mentioned for implementations which do support the above). The current wording of the availability of `os.lchmod()` is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added. Data for the BSDs taken from their online manpages. Signed-off-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX specifies that implementations are not required to support changing the file mode of symbolic links, but may do so.
Consequently,
lchmod()is not part of POSIX (but mentioned for implementations which do support the above).The current wording of the availability of
os.lchmod()is rather vague and improved to clearly tell which POSIX/Unix/BSD-like support the function in general (those that support changing the file mode of symbolic links). Further, some examples of major implementations are added.Data for the BSDs taken from their online manpages.
os.lchmod()is missing #107959📚 Documentation preview 📚: https://cpython-previews--107960.org.readthedocs.build/