Skip to content

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py #107971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 16, 2023
Merged

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py #107971

merged 18 commits into from
Aug 16, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 15, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 15, 2023
Closed
@iritkatriel iritkatriel marked this pull request as draft August 15, 2023 12:01
@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Aug 15, 2023
ericsnowcurrently
ericsnowcurrently approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I've left a couple comments where there might be something further to be done.

(I'm approving under the assumption the comments will be resolved first, one way or another.)

@iritkatriel
Copy link
Member Author

Mostly LGTM. I've left a couple comments where there might be something further to be done.

Thanks. A couple of tests for tracing/instrumentation are failing, I'm still debugging that.

@brettcannon brettcannon removed their request for review August 15, 2023 21:57
@iritkatriel iritkatriel marked this pull request as ready for review August 16, 2023 16:17
@iritkatriel iritkatriel requested a review from a team as a code owner August 16, 2023 16:17
@iritkatriel iritkatriel requested a review from gvanrossum August 16, 2023 16:42
gvanrossum
gvanrossum approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revolution! It's almost here!!

A few nits but no need to wait for a re-review.

Lib/test/test_dis.py
@@ -1617,197 +1616,197 @@ def _prepare_test_cases():
Instruction = dis.Instruction

expected_opinfo_outer = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is just preposterous. Let's commit to doing this in a different way in a future PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markshannon loves to hate this test too.

@iritkatriel iritkatriel enabled auto-merge (squash) August 16, 2023 22:13
@iritkatriel iritkatriel merged commit 665a439 into python:main Aug 16, 2023
@markshannon markshannon mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @ericsnowcurrently @gvanrossum @bedevere-bot @Eclips4