Skip to content

gh-107298: Fix C API datetime documentation #108034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 16, 2023

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to ignore my remarks (or address them in a separated PR).

@serhiy-storchaka serhiy-storchaka merged commit d63972e into python:main Aug 21, 2023
@serhiy-storchaka serhiy-storchaka deleted the docs-capi-datetime branch August 21, 2023 18:15
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d63972e289e05b0d82e59f32f107312a8b3de7b5 3.12

@bedevere-bot bedevere-bot requested a review from vstinner August 21, 2023 18:16
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-108233 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 21, 2023
@serhiy-storchaka
Copy link
Member Author

Thank you for your review @vstinner.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 21, 2023
…8034).

(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-108234 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 21, 2023
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
ambv pushed a commit that referenced this pull request Aug 22, 2023
(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants