gh-106581: Project through calls #108067
Merged
gh-106581: Project through calls #108067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This uses the function-by-version cache I just added - There's not yet a way to trace back via `RETURN_VALUE`
This should fix leaks and hopefully most failing tests.
Macros not using oparg should have a format starting with IX, not IB. This corrects the metadata for a bunch of specializations, e.g. BINARY_OP_MULTIPLY_INT (which never looks at oparg).
Seems to fix test_opcache, playing games with func.__code__ = func.__code__.replace().
gvanrossum
changed the title
Comment on lines
+274
to
+275
| interp->func_state.func_version_cache[ | ||
| version % FUNC_VERSION_CACHE_SIZE] = func; |
There was a problem hiding this comment.
I think this would be slightly more readable with something like this:
Suggested change
| interp->func_state.func_version_cache[ | |
| version % FUNC_VERSION_CACHE_SIZE] = func; | |
| uint32_t idx = version % FUNC_VERSION_CACHE_SIZE; | |
| interp->func_state.func_version_cache[idx] = func; |
Ditto for the function below.
There was a problem hiding this comment.
Oh, sorry. It's probably not worth it to clean this up now that I landed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the work begun in gh-107760. When, while projecting a superblock, we encounter a call to a short, simple function, the superblock will now enter the function using
_PUSH_FRAME, continue through it, and leave it using_POP_FRAME, and then continue through the original code. Multiple frame pushes and pops are even possible. It is also possible to stop appending to the superblock in the middle of a called function, when running out of space or encountering an unsupported bytecode.(I had two previous draft PRs covering this work, gh-107793 and gh-107925, but I decided to combine them.)