Skip to content

gh-108179: Add error message for parser stack overflows #108256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2023
Merged

gh-108179: Add error message for parser stack overflows #108256

merged 3 commits into from
Aug 22, 2023

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Aug 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 22, 2023
Closed
pablogsal
pablogsal approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this version! Great job @sweeneyde 🤘

@pablogsal pablogsal merged commit 8661751 into python:main Aug 22, 2023
@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 22, 2023
@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@pablogsal pablogsal removed the needs backport to 3.10 only security fixes label Aug 22, 2023
@miss-islington
Copy link
Contributor

Sorry, @sweeneyde and @pablogsal, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 86617518c4ac824e2b6dc20691ba5a08df04f285 3.11

@miss-islington
Copy link
Contributor

Sorry, @sweeneyde and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 86617518c4ac824e2b6dc20691ba5a08df04f285 3.10

@pablogsal
Copy link
Member

I am quite sure the backports need to be done manually. Could you take care of them @sweeneyde ?

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
@sweeneyde @miss-islington
pythongh-108179: Add error message for parser stack overflows (python…
878c82d 
…GH-108256)

(cherry picked from commit 8661751)

Co-authored-by: Dennis Sweeney <[email protected]>
@bedevere-bot
Copy link

GH-108263 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 22, 2023
Yhg1s pushed a commit that referenced this pull request Aug 22, 2023
@miss-islington @sweeneyde
[3.12] gh-108179: Add error message for parser stack overflows (GH-10…
149d70c 
…8256) (#108263)

gh-108179: Add error message for parser stack overflows (GH-108256)
(cherry picked from commit 8661751)

Co-authored-by: Dennis Sweeney <[email protected]>
@hugovk hugovk removed the needs backport to 3.11 only security fixes label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sweeneyde @miss-islington @pablogsal @bedevere-bot @hugovk