Skip to content

GH-108614: Add RESUME_CHECK instruction #108630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 29, 2023

Minimizes overhead of checking for instrumentation and signals in the tier 2 interpreter, and reduces the need for #if TIER_ONE special casing.

@brettcannon
Copy link
Member

I think this may have broken the Emscripten builds:

In file included from ../../Python/ceval.c:767:
../../Python/generated_cases.c.h:31:22: error: use of undeclared identifier 'emscripten_signal_clock'
            DEOPT_IF(emscripten_signal_clock == 0, RESUME);
                     ^
../../Python/generated_cases.c.h:32:13: error: use of undeclared identifier 'emscripten_signal_clock'
            emscripten_signal_clock -= Py_EMSCRIPTEN_SIGNAL_HANDLING;
            ^
2 errors generated.
emcc: error: 'ccache /opt/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -DEMSCRIPTEN -D__EMSCRIPTEN_major__=3 -D__EMSCRIPTEN_minor__=1 -D__EMSCRIPTEN_tiny__=22 -Werror=implicit-function-declaration -I/opt/buildbot/.emscripten_cache/sysroot/include/SDL --sysroot=/opt/buildbot/.emscripten_cache/sysroot -Xclang -iwithsysroot/include/compat -c -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g3 -O3 -Wall -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I../../Include/internal -IObjects -IInclude -IPython -I. -I../../Include -fPIC -DPy_BUILD_CORE ../../Python/ceval.c -o Python/ceval.o' failed (returned 1)
make: *** [Makefile:2691: Python/ceval.o] Error 1
make: *** Waiting for unfinished jobs....
emmake: error: 'make -j2 all' failed (returned 2)

@markshannon markshannon deleted the quick-resume branch September 8, 2023 09:37
@vstinner
Copy link
Member

According to @iritkatriel bisect, this change introduced a regression: #109198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants