gh-108374: Add --disable-gil option to PCbuild/build.bat #108729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `--disable-gil` option to PCbuild/build.bat. For now, all this does is define the Py_NOGIL macro.
colesbury
added
OS-windows
skip news
build
|
I'm not familiar with msbuild, so I'd appreciate feedback if this is the correct approach. |
|
This looks reasonable to me, but should definitely get signoff from @zooba before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--disable-giloption to PCbuild/build.bat. For now, all this does is define thePy_NOGILmacro.--disable-giloption for Windows builds #108374