-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-109094: replace frame->prev_instr by frame->instr_ptr #109095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iritkatriel
commented
Sep 7, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Replace frame->prev_instr by frame->instr_ptr #109094
7bb3b93
to
da6c97b
Compare
2cfbdbf
to
557f36f
Compare
For me, the only thing that prevent this from being merged is the failing gdb test. Maybe you can get help on Discord? Mark should still review it one more time. |
(When you turn on uops all the time there are some additional failures in |
I'll look into the gdb tests tomorrow. |
I have made the requested changes; please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments and questions, but looks good overall.
All test except |
I have made the requested changes; please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A definite improvement over the increasingly mis-named prev_instr