Skip to content

gh-108455: peg_generator: enable mypy's --warn-unreachable setting and redundant-expr error code #109160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

gh-108455: peg_generator: enable mypy's --warn-unreachable setting and redundant-expr error code #109160

merged 1 commit into from
Sep 8, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 8, 2023 •
edited by bedevere-bot
Loading

Closes #108455

The changes to the .py files are all due to branches that mypy flagged as being unreachable.

@AlexWaygood AlexWaygood requested a review from sobolevn September 8, 2023 19:05
@bedevere-bot bedevere-bot mentioned this pull request Sep 8, 2023
Closed
@pablogsal pablogsal merged commit 697c9dc into python:main Sep 8, 2023
@pablogsal
Copy link
Member

Thanks a lot @AlexWaygood !

@AlexWaygood AlexWaygood deleted the pegen-reachability branch September 8, 2023 21:18
@AlexWaygood
Copy link
Member Author

You're very welcome @pablogsal, thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run mypy on Tools/peg_generator
3 participants
@AlexWaygood @pablogsal @bedevere-bot