-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-109375: Fix bug where pdb registers an alias without an associated command #109376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
88b9e45
to
37a1969
Compare
An unkown alias without a given command should not register a new alias.
37a1969
to
1393e36
Compare
Co-authored-by: Tian Gao <[email protected]>
d93460f
to
0fae8eb
Compare
I included the proposed changes. There was a failing test, because of an additional '.' ( |
You don't need to squash any commits on your feature branch. In fact, that is discouraged as it might make code review harder (to track the previous changes). The maintainers will squash all your commits when merging. The code looks good to me. @iritkatriel |
@gaogaotiantian Is this a bugfix (should it be backported)? |
Misc/NEWS.d/next/Library/2023-09-13-17-22-44.gh-issue-109375.ijJHZ9.rst
Outdated
Show resolved
Hide resolved
@buermarc thanks for the fix. I see this is your first PR in this repo. Care to add your name to the |
Thanks for the reviewes
That makes sense. Thanks for the info!
I added my name, and tried to follow the "rough" alphabetical order :) |
I think we should backport it. It prevents |
Ha! I was not even in the list! |
Add yourself in your next PR. |
Thanks @buermarc for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ciated command (pythonGH-109376) (cherry picked from commit 68a6f21) Co-authored-by: buermarc <[email protected]>
GH-109429 is a backport of this pull request to the 3.12 branch. |
…ciated command (pythonGH-109376) (cherry picked from commit 68a6f21) Co-authored-by: buermarc <[email protected]>
GH-109430 is a backport of this pull request to the 3.11 branch. |
|
|
|
|
|
|
|
Issue: #109375
An unkown alias without a given command should not register a new alias.