Skip to content

gh-103053: Run tools test_freeze on buildbot #110458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 6, 2023

No longer skip test_tools.test_freeze on buildbots.

Remove test.support.skip_if_buildbot() function.

The skip was added when freeze tests were added in
commit 13d9205.
@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

I fixed test_freeze on FreeBSD in PR #110451.

@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 4fab683 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

buildbot/ARM Raspbian PR — Build done.

test_tools failed with with a 40 min timeout and a system load of 6.28.

0:42:03 load avg: 6.28 [260/467/1] test_tools worker non-zero exit code (Exit code 1) -- running (2): test_zipfile (2 min 43 sec), test.test_concurrent_futures.test_deadlock (8 min 23 sec)
test_freeze_simple_script (test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script) ... Timeout (0:40:00)!
Thread 0xf7ded040 (most recent call first):
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Lib/selectors.py", line 398 in select
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Lib/subprocess.py", line 2108 in _communicate
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Lib/subprocess.py", line 1209 in communicate
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Lib/subprocess.py", line 550 in run
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Tools/freeze/test/freeze.py", line 35 in _run_quiet
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Tools/freeze/test/freeze.py", line 170 in freeze
  File "/var/lib/buildbot/workers/pull_request.gps-raspbian.nondebug/build/Lib/test/test_tools/test_freeze.py", line 32 in test_freeze_simple_script

The test pass when re-run, but it took 36 min!

1:48:58 load avg: 3.00 running (1): test_tools (35 min 18 sec)
1:49:28 load avg: 3.55 running (1): test_tools (35 min 48 sec)
1:49:45 load avg: 3.26 [2/2] test_tools passed (36 min 4 sec)
Re-running test_tools in verbose mode
(...)
Ran 36 tests in 2163.293s

build: https://buildbot.python.org/all/#/builders/1062/builds/415

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

PPC64LE RHEL7 Refleaks PR failed with test_functools leaked [1, 1, 1] memory blocks, sum=3: that's unrelated issue gh-110096.

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

s390x Fedora Clang PR failed with FAIL: test_pipesize_default (test.test_subprocess.ProcessTestCaseNoPoll.test_pipesize_default): unrelated issue gh-110184.

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

@gpshead: Apparently, test_tools only fails on your ARM Raspbian PR buildbot. I see different options:

  • Disable cpu resources on this buildbot to skip slowest tests like test_tools
  • Increaes timeout from 40 min to 1 hour or even more
  • Another option to only skip test_tools on this buildbot

What do you prefer? I prefer to disable the cpu resources. I would prefer a fast CI quick runs most tests, than a slow CI which fail time to time with timeout.

@vstinner
Copy link
Member Author

vstinner commented Nov 8, 2023

I'm not sure that it's really worth it to run test_freeze on more CIs. The test is slow and I don't really understand why this tool is maintained in Python itself (which is not even installed by make install). Well, I just close my PR.

@vstinner vstinner closed this Nov 8, 2023
@gpshead
Copy link
Member

gpshead commented Nov 8, 2023

python/buildmaster-config#441 to add -u-cpu for whomever can approve it.

the bot will become 3x faster whenever I can get my hand on a shiny new RaspberryPi 5.

@vstinner vstinner deleted the freeze_buildbot3 branch January 14, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants