gh-84570: Implement Waiting in SendChannel.send() #110565

ericsnowcurrently · 2023-10-09T13:48:35Z

We had been faking it (poorly).

We will add timeouts separately.

Issue: [subinterpreters] Implement _xxsubinterpreters.channel_send_wait() #84570

There were a few things I did in gh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by gh-110246. I'll take care of that separately.)

There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)

) We had been faking it (poorly). We will add timeouts separately.

There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)

ericsnowcurrently added 4 commits October 9, 2023 07:45

Implement waiting for _channels.send().

c617361

Release the GIL while waiting for the send lock.

1701ca0

Fix tests.

b5dbf81

Update the doc strings.

d3aefb8

ericsnowcurrently added the skip news label Oct 9, 2023

bedevere-app bot added the awaiting review label Oct 9, 2023

ericsnowcurrently changed the title ~~Implement Waiting in SendChannel.send()~~ gh-84570: Implement Waiting in SendChannel.send() Oct 9, 2023

bedevere-app bot mentioned this pull request Oct 9, 2023

[subinterpreters] Implement _xxsubinterpreters.channel_send_wait() #84570

Closed

ericsnowcurrently mentioned this pull request Oct 9, 2023

bpo-32604: [_xxsubinterpreters] Add channel_send_wait(). #19829

Closed

ericsnowcurrently added 3 commits October 9, 2023 08:18

Wait when receiving from a thread.

5b6574e

wait -> blocking

fbd7945

Fix the tests.

b85a681

ericsnowcurrently enabled auto-merge (squash) October 10, 2023 09:23

ericsnowcurrently merged commit 757cc35 into python:main Oct 10, 2023

bedevere-app bot removed the awaiting review label Oct 10, 2023

ericsnowcurrently deleted the channel-send-wait-new branch October 10, 2023 09:38

ericsnowcurrently mentioned this pull request Oct 17, 2023

gh-84570: Send-Wait Fixes for _xxinterpchannels #111006

Merged

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-84570: Implement Waiting in SendChannel.send() (pythongh-110565

6290e1a

) We had been faking it (poorly). We will add timeouts separately.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-84570: Implement Waiting in SendChannel.send() #110565

gh-84570: Implement Waiting in SendChannel.send() #110565

ericsnowcurrently commented Oct 9, 2023 •

edited by bedevere-app bot

Loading

gh-84570: Implement Waiting in SendChannel.send() #110565

gh-84570: Implement Waiting in SendChannel.send() #110565

Conversation

ericsnowcurrently commented Oct 9, 2023 • edited by bedevere-app bot Loading

ericsnowcurrently commented Oct 9, 2023 •

edited by bedevere-app bot

Loading