Skip to content

gh-106344 return ciphers in SSLSocket.shared_ciphers() after session reuse #110902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kevinAlbs
Copy link

@kevinAlbs kevinAlbs commented Oct 15, 2023

Store client sent ciphers from the hello message. Revise SSLSocket.shared_ciphers() to return the intersection of client and server ciphers. This results in SSLSocket.shared_ciphers() returning ciphers after an SSL session is reused.

This is an alternative resolve: #106344

@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSLSocket.shared_ciphers() does not document None is returned on session reuse
1 participant