Skip to content

gh-111085 Fix logic order causing nicer error to never be raised in asyncio.Timeout #110910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-111085 Fix logic order causing nicer error to never be raised in asyncio.Timeout #110910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4071cd6
Fix logic order causing nicer error to never be raised
Gobot1234 Oct 15, 2023
10317ea
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 19, 2023
35453e2
Update and rename 2023-10-19-11-40-38.gh-issue-0.hBPpQr.rst to 2023-1…
Gobot1234 Oct 19, 2023
a2608eb
Update ACKS
Gobot1234 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/asyncio/timeouts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ def __repr__(self) -> str:
async def __aenter__(self) -> "Timeout":
self._state = _State.ENTERED
self._task = tasks.current_task()
self._cancelling = self._task.cancelling()
if self._task is None:
raise RuntimeError("Timeout should be used inside a task")
self._cancelling = self._task.cancelling()
self.reschedule(self._when)
return self

Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ Aaron Hill
Joel Hillacre
Richie Hindle
Konrad Hinsen
James Hilton-Balfe
Richard Hoberecht
David Hobley
Tim Hochberg
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-10-19-11-40-38.gh-issue-111085.hBPpQr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :class:`asyncio.Timeout` raising an :exc:`AttributeError` over a :exc:`RuntimeError` due to logic bug. Patch by James Hilton-Balfe