Skip to content

gh-111157: Mention __notes__ in traceback.format_exception_only docstring #111158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 21, 2023

@iritkatriel
Copy link
Member

In #109201 I made a similar update to the docs. Indeed I missed out the docstring.

Have a look at that change - it's a bit larger because with notes it's no longer true that "normally the list contains a single string".

@iritkatriel iritkatriel added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 21, 2023
@iritkatriel iritkatriel enabled auto-merge (squash) October 21, 2023 15:03
@iritkatriel iritkatriel merged commit 5e7727b into python:main Oct 21, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2023
…nly` docstring (pythonGH-111158)

(cherry picked from commit 5e7727b)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2023
…nly` docstring (pythonGH-111158)

(cherry picked from commit 5e7727b)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2023

GH-111163 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 21, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2023

GH-111164 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 21, 2023
iritkatriel pushed a commit that referenced this pull request Oct 21, 2023
…only` docstring (GH-111158) (#111164)

gh-111157: Mention `__notes__` in `traceback.format_exception_only` docstring (GH-111158)
(cherry picked from commit 5e7727b)

Co-authored-by: Nikita Sobolev <[email protected]>
iritkatriel pushed a commit that referenced this pull request Oct 21, 2023
…only` docstring (GH-111158) (#111163)

gh-111157: Mention `__notes__` in `traceback.format_exception_only` docstring (GH-111158)
(cherry picked from commit 5e7727b)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants