gh-111159: Fix doctest output comparison for exceptions with notes
#111160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Oct 21, 2023
|
Thanks for doing this. Are you up for adding Exception Groups to doctest too? #104150 |
I will take a look :) |
iritkatriel
reviewed
Oct 21, 2023
iritkatriel
approved these changes
Oct 21, 2023
Co-authored-by: Irit Katriel <[email protected]>
iritkatriel
added
needs backport to 3.11
|
Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2023
…notes (pythonGH-111160) (cherry picked from commit fd60549) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2023
…notes (pythonGH-111160) (cherry picked from commit fd60549) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-111169 is a backport of this pull request to the 3.12 branch. |
|
GH-111170 is a backport of this pull request to the 3.11 branch. |
iritkatriel
pushed a commit
that referenced
this pull request
Oct 21, 2023
iritkatriel
pushed a commit
that referenced
this pull request
Oct 21, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we need more tests for this? What else can be added?
doctestfails to compare tracebacks with notes #111159